Gym mode UI Updates - #1255
Draft
jontyms wants to merge 1 commit into
Draft
Conversation
2 tasks
Member
|
hey! thanks for the PR. I don't think I can merge this as it is (I think it makes the screen a bit restless), but there's definitely some good ideas here. I've marked this for the next release so it doesn't get lost |
Rework the gym-mode logging experience around a redesigned log page, rebased onto current master: - Split the monolithic log_page.dart into focused widgets under log_page/ (chrome, hero, palette, set_panel, sets_section, sheets). - Add a dedicated rest-timer notifier so the inline rest timer runs off shared state instead of ad-hoc timers. - Support a dynamic number of sets per page and per-set editing via bottom sheets. - Add gym-mode theme extensions and a local palette for the new UI. - Extend gym state and wire up navigation, start page, summary and the workout menu accordingly; drop the now-unused standalone timer page and header menu button in favor of the new navigation. - Make the horizontal action bar scroll like the exercise-queue strip (touch/mouse/trackpad drag + mouse-wheel to horizontal). - Add the accompanying l10n strings. - Rework log_page and gym_mode widget/integration tests for the redesigned logging UI and dynamic sets; refresh the affected goldens. - Fix json_serializable codegen for SetConfigData.exercise (the exclusion annotation needs to live on the getter, not the private backing field). - Drop gym_log_notifier: the redesigned log page was its last production caller, leaving the provider referenced only by its own test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CSJFoyiDE1RTcmf9G5tfGR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Reworks gym mode around a single active-session screen: everything lives on, or one tap away from, the log page. The old per-set / per-timer chevron flow is replaced by a swipeable page-per-exercise with persistent chrome (session header + scrollable exercise queue).
This PR is heavily AI generated but I have tested and used this prototype for weeks.
Related Issue(s)
Please check that the PR fulfills these requirements
dart format .)