086 amendments following extendedViewer toggle removal#152
Open
rcantin-w wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates RFC 086 (“IIIF Viewer Context Refactoring”) documentation to reflect the post-extendedViewer-removal architecture, and expands the manual testing guidance with a scenario matrix and concrete example works.
Changes:
- Updates RFC text to describe the viewer as the unconditional rendering path for non-image content (video/audio/PDF) and archives.
- Adds a user-scenarios matrix and standardised prod/dev links for a comprehensive set of example test works.
- Adjusts wording across phases/future improvements to remove references to previously-flagged behaviour.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
rfcs/086-item-viewer-refactor/08-phase-2-split-components.md |
Updates Phase 2 component split narrative to explicitly include video/audio/PDF in the non-image-only path. |
rfcs/086-item-viewer-refactor/14-testing-strategy.md |
Adds a scenario matrix plus detailed, linked example works for manual testing across auth/access states. |
rfcs/086-item-viewer-refactor/16-future-improvements.md |
Tweaks future-improvements examples to align terminology around non-image-only rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates RFC 086 (IIIF Viewer Context Refactoring) to reflect the current state of the codebase following the removal of the
extendedViewerfeature flag in wellcomecollection/wellcomecollection.org#13129. The RFC now presents the architecture as-is, without references to previously removed features.Background
The
extendedViewertoggle controlled whether the viewer could render video, audio, and PDFs. It defaulted tofalse, meaning most production traffic used a separateIIIFItemListcomponent for non-image content. The toggle has been removed andextendedViewer = trueis now the permanent default.Changes Made
1. Removed Temporal References
All "post-PR #13129" notes have been removed from:
01-overview.md- Removed note aboutuseFeatureFlags/useUserContextimports08-phase-2-split-components.md- Removed "Before (post-PR #13129)" framing and note aboutIIIFItemList14-testing-strategy.md- Removed note aboutextendedViewertoggle15-risks-and-success.md- Removed note about loss of fallback rollback optionThe RFC now describes the current architecture without suggesting these features previously existed differently.
2. Cleaned Up References to Removed Concepts
Removed all references to:
IIIFItemListcomponent as an alternative rendering pathhasOriginalPdf/hasItemTypeguardsuserIsStaffWithRestrictedas a component-rendering conditionextendedViewerfeature flaguseFeatureFlagsanduseUserContextimportsmainImageService,iiifImageLocation, or user type3. Maintained Accurate Terminology
Preserved "mixed content" terminology, which correctly describes born digital works containing a mixture of media types (PDFs, audio, videos) in the same viewer.
4. Enhanced Testing Documentation
Added User Scenarios Matrix
Created comprehensive table in
14-testing-strategy.mdshowing all combinations of:Added Complete Test Work Examples
Added work IDs for all scenarios:
Unrestricted/Open Access:
a55dcp3hb5kqccbba222zvgendx5vuhydn9jwck6a9w3qy3jRestricted/Special Access:
pnud3fzbrp9jnamuesd6gs3szsgh5y3zmy6bzerrStandardized Link Format
All work links now use consistent format:
Testing Impact
The testing strategy now provides:
Outcome
The RFC now hopefully accurately reflects the current codebase state where: