Skip to content

086 amendments following extendedViewer toggle removal#152

Open
rcantin-w wants to merge 6 commits into
mainfrom
86-amendments
Open

086 amendments following extendedViewer toggle removal#152
rcantin-w wants to merge 6 commits into
mainfrom
86-amendments

Conversation

@rcantin-w

Copy link
Copy Markdown
Contributor

Summary

This PR updates RFC 086 (IIIF Viewer Context Refactoring) to reflect the current state of the codebase following the removal of the extendedViewer feature flag in wellcomecollection/wellcomecollection.org#13129. The RFC now presents the architecture as-is, without references to previously removed features.

Background

The extendedViewer toggle controlled whether the viewer could render video, audio, and PDFs. It defaulted to false, meaning most production traffic used a separate IIIFItemList component for non-image content. The toggle has been removed and extendedViewer = true is now the permanent default.

Changes Made

1. Removed Temporal References

All "post-PR #13129" notes have been removed from:

  • 01-overview.md - Removed note about useFeatureFlags/useUserContext imports
  • 08-phase-2-split-components.md - Removed "Before (post-PR #13129)" framing and note about IIIFItemList
  • 14-testing-strategy.md - Removed note about extendedViewer toggle
  • 15-risks-and-success.md - Removed note about loss of fallback rollback option

The RFC now describes the current architecture without suggesting these features previously existed differently.

2. Cleaned Up References to Removed Concepts

Removed all references to:

  • IIIFItemList component as an alternative rendering path
  • hasOriginalPdf / hasItemType guards
  • userIsStaffWithRestricted as a component-rendering condition
  • extendedViewer feature flag
  • useFeatureFlags and useUserContext imports
  • Guards on mainImageService, iiifImageLocation, or user type

3. Maintained Accurate Terminology

Preserved "mixed content" terminology, which correctly describes born digital works containing a mixture of media types (PDFs, audio, videos) in the same viewer.

4. Enhanced Testing Documentation

Added User Scenarios Matrix

Created comprehensive table in 14-testing-strategy.md showing all combinations of:

  • Work types: Multi-canvas images, single canvas, archives, video/audio, PDFs, mixed content, content advisory, restricted content
  • Authentication states: Logged out, logged in (regular), logged in (restricted)
  • Access types: ✓ Open, 🔒 Restricted, ⚠️ Content advisory

Added Complete Test Work Examples

Added work IDs for all scenarios:

Unrestricted/Open Access:

  • Multi-canvas images: a55dcp3h
  • Single canvas: b5kqccbb
  • Archive items: a222zvge
  • PDF: ndx5vuhy
  • Mixed media (born digital): dn9jwck6
  • Video/audio: a9w3qy3j

Restricted/Special Access:

  • Content advisory (clickthrough): pnud3fzb
  • Restricted whole item: rp9jnamu
  • Restricted audio: esd6gs3s
  • Restricted video: zsgh5y3z
  • Restricted born digital: my6bzerr

Standardized Link Format

All work links now use consistent format:

- Work page: [prod](https://wellcomecollection.org/...) | [dev](https://www-dev.wellcomecollection.org/...)
- Items page: [prod](https://wellcomecollection.org/...) | [dev](https://www-dev.wellcomecollection.org/...)

Testing Impact

The testing strategy now provides:

  • Clear matrix of all user scenarios that need coverage
  • Specific work IDs for testing each scenario
  • Both production and development URLs for easy access
  • Consistent organization by work type and authentication state

Outcome

The RFC now hopefully accurately reflects the current codebase state where:

  • The viewer is the single, unconditional rendering path for all content types
  • Video, audio, and PDF content always renders in the viewer
  • All test scenarios have specific example works for validation
  • Documentation is forward-looking without references to removed features

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RFC 086 (“IIIF Viewer Context Refactoring”) documentation to reflect the post-extendedViewer-removal architecture, and expands the manual testing guidance with a scenario matrix and concrete example works.

Changes:

  • Updates RFC text to describe the viewer as the unconditional rendering path for non-image content (video/audio/PDF) and archives.
  • Adds a user-scenarios matrix and standardised prod/dev links for a comprehensive set of example test works.
  • Adjusts wording across phases/future improvements to remove references to previously-flagged behaviour.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
rfcs/086-item-viewer-refactor/08-phase-2-split-components.md Updates Phase 2 component split narrative to explicitly include video/audio/PDF in the non-image-only path.
rfcs/086-item-viewer-refactor/14-testing-strategy.md Adds a scenario matrix plus detailed, linked example works for manual testing across auth/access states.
rfcs/086-item-viewer-refactor/16-future-improvements.md Tweaks future-improvements examples to align terminology around non-image-only rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rfcs/086-item-viewer-refactor/08-phase-2-split-components.md Outdated
Comment thread rfcs/086-item-viewer-refactor/14-testing-strategy.md Outdated
Comment thread rfcs/086-item-viewer-refactor/14-testing-strategy.md Outdated
Comment thread rfcs/086-item-viewer-refactor/14-testing-strategy.md Outdated
Comment thread rfcs/086-item-viewer-refactor/16-future-improvements.md Outdated
rcantin-w and others added 5 commits June 12, 2026 17:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rcantin-w rcantin-w marked this pull request as ready for review June 12, 2026 16:13
@rcantin-w rcantin-w requested review from a team as code owners June 12, 2026 16:13
@rcantin-w rcantin-w removed the request for review from a team June 12, 2026 16:13
@rcantin-w rcantin-w moved this from Backlog to Ready for review in Digital experience Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

3 participants