Skip to content

Add onResourceSaved and onResourceError changes to migration guide - #669

Merged
aivus merged 1 commit into
masterfrom
migration-notification-actions
Nov 8, 2026
Merged

aivus merged 1 commit into
masterfrom
migration-notification-actions

Conversation

@aivus

@aivus aivus commented Nov 8, 2026

Copy link
Copy Markdown
Member

Documents the behavior changes from #658 and #668 in the "From version 6 to 7" section of MIGRATION.md:

  • scrape() waits for pending onResourceSaved / onResourceError actions before afterFinish and resolving. A slow action delays scrape(), and one that never settles makes it hang.
  • A failing onResourceSaved respects ignoreErrors: with the default false, scrape() rejects. In v6 it caused an unhandled rejection.
  • A failing onResourceError is only logged. In v6 it caused an unhandled rejection.
  • Before/after example: plugins no longer need to track their own promises and await them in afterFinish.

Docs only.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aivus
aivus merged commit b4fc11c into master Nov 8, 2026
14 checks passed
@aivus
aivus deleted the migration-notification-actions branch November 8, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant