Repository navigation
Conversation
This was referenced Sep 28, 2026
Collaborator
Author
|
Closing this as unnecessary for the Edge N-API integration. A libc change only affects newly rebuilt WASIX guests, while this work must support the released EdgeJS atom unchanged. The host-side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was an optional guest-side correction for future sysroot builds. It changed
waitpid(WNOHANG)to recognize the WASIX pending status before requiring a completed-child PID, and allowed POSIXwaitpid(..., NULL, ...)for completed children.It is closed because the Edge integration must run the released EdgeJS WASM unchanged. Wasmer #7046 instead returns the legacy-compatible
Some(0)plusNothingpending result from the host, so the released PID-first libc works without a guest rebuild. The test remains useful evidence but is not part of the rollout dependency chain.Validation
-Wall -Wextra -Werror.f45c39b; all runs printedWAITPID_NONBLOCKING_OKand exited 0.pid=-1 errno=12, confirming the regression detects the old behavior.bash -nandgit diff --checkpassed.Fresh independent Astra reviews approved exact head
e18b16a0bce82689f1b702be5a995e02ec6f9483; the post-fix review found no remaining blockers.