Repository navigation
fix(signal): terminate without raising SIGABRT - #132
Open
syrusakbary wants to merge 1 commit into
Open
syrusakbary wants to merge 1 commit into
syrusakbary wants to merge 1 commit into
Conversation
Arshia001
suggested changes
Aug 31, 2026
Arshia001
left a comment
There was a problem hiding this comment.
Tests for wasix-libc fixes and new features are added in the Wasmer repo, under wasix/tests/wasm_tests. Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
128 + signalstatusSA_SIGINFO,SA_RESETHAND, and defaultSIGTERMRoot cause
WASIX libc implemented every default terminating signal by calling
abort(). That raisesSIGABRTwhile the original signal is still being dispatched. A runtime that immediately delivers the nested signal can therefore re-enter the default signal path and repeatedly callabort(), producing an abort cascade instead of terminating once.The terminating default action does not need the abort path or core-signal semantics.
_Exit(128 + sig)terminates once and exposes the conventional shell status without writing diagnostics to stderr.Verification
wasm32exnref/EH sysroot with./build32-exnref-eh.shSA_SIGINFO,SA_RESETHAND, and defaultSIGTERMthrough the Wasmer JavaScript SDK: exit statuses0,138, and143; no termination or abort diagnosticsCollecting build traces, verified.next/BUILD_ID, and served the production preview successfully