Repository navigation
Conversation
There was a problem hiding this comment.
Requesting changes — the stray result symlink needs to go (flagged inline), plus one stale comment in poll.c.
Verified fine: POLLPRI 0x4 doesn't collide with anything in __header_poll.h (0x1/0x2/0x1000/0x2000/0x4000); __WASI_RIFLAGS_RECV_OOB (bit 4) and __WASI_SIFLAGS_SEND_OOB (bit 1) match wasmer's types.rs; pselect.c's &empty aliasing when several sets are NULL is safe, and its return-value summing is correct.
Dropping #define EPOLLPRI EPOLLIN from musl/include/poll.h is a genuine fix independent of this feature — that macro was shadowing sys/epoll.h's EPOLLPRI 0x002 in any TU that included both, silently degrading epoll EPOLLPRI to EPOLLIN. Worth calling out in the commit message rather than burying it here.
Note the runtime side (wasmerio/wasmer#6861) has blocking issues of its own.
Adds support for TCP OOB
Requires wasix-org/wasix-witx#9 to be merged first (and submodule pointers here updated respectively if they end up with different commit hashes upon merge)
Requires wasmerio/wasmer#6861 for runtime support
Part of https://linear.app/wasmer/issue/WAX-604/implement-tcp-oob-handling-for-selectpselect-exceptfds
Wasinix downstream context
libc-select-exceptfds.patch