Repository navigation
fix: pytest was declared as runtime dependency - #36
Merged
Merged
Conversation
pyproject.toml [project].dependencies declared pytest>=9.0.3, so 'pip install pyvyos==0.4.0' pulled pytest into every install. This contradicted the 0.4.0 CHANGELOG which advertised runtime deps as 'requests>=2.32.0,<3.0 only'. The line was introduced accidentally during the e2e harness work in bfcaffe (almost certainly an 'uv add pytest' that landed in the wrong table) and was not caught in review. Removed; pytest remains in the 'dev' optional-dependency extra. Bump to 0.4.1 to ship the correction to PyPI.
…deps # Conflicts: # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.toml [project].dependencies declared pytest>=9.0.3, so 'pip install pyvyos==0.4.0' pulled pytest into every install. This contradicted the 0.4.0 CHANGELOG which advertised runtime deps as 'requests>=2.32.0,<3.0 only'.
The line was introduced accidentally during the e2e harness work in bfcaffe (almost certainly an 'uv add pytest' that landed in the wrong table) and was not caught in review.
Removed; pytest remains in the 'dev' optional-dependency extra.
Bump to 0.4.1 to ship the correction to PyPI.