build: add engines field for bundlers and devEngines field for root#1705
Open
Mister-Hope wants to merge 1 commit into
Open
build: add engines field for bundlers and devEngines field for root#1705Mister-Hope wants to merge 1 commit into
Mister-Hope wants to merge 1 commit into
Conversation
Coverage Report for CI Build 25904201869Coverage remained the same at 72.961%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR updates runtime/tooling constraints across the monorepo by tightening Node.js version requirements for published bundler packages and switching the root project to a devEngines-based declaration for Node/pnpm requirements.
Changes:
- Update
@vuepress/vuepressNode engine range to a major-version allowlist (22/24/26). - Add matching
engines.nodeconstraints to@vuepress/bundler-viteand@vuepress/bundler-webpack. - Replace the root
packageManagerpin with adevEnginesdeclaration for pnpm + Node.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/vuepress/package.json | Changes the engines.node range from a broad >= requirement to a major allowlist. |
| packages/bundler-webpack/package.json | Adds engines.node to constrain supported Node majors for the webpack bundler package. |
| packages/bundler-vite/package.json | Adds engines.node to constrain supported Node majors for the vite bundler package. |
| package.json | Removes top-level packageManager pin and adds devEngines for Node + pnpm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+61
| "devEngines": { | ||
| "packageManager": { | ||
| "name": "pnpm", | ||
| "version": "11.1.2", | ||
| "onFail": "download" | ||
| }, |
| }, | ||
| "runtime": { | ||
| "name": "node", | ||
| "version": "^22.18.0 || ^24.0.0 || ^26.0.0", |
Member
There was a problem hiding this comment.
The purpose of the root package.json changes are different. Let's split it to a separate PR. Also this comment is valid
| }, | ||
| "engines": { | ||
| "node": ">=22.18.0" | ||
| "node": "^22.18.0 || ^24.0.0 || ^26.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.