Skip to content

fix(bundler-webpack): improve default value for module.noParse#1702

Merged
meteorlxy merged 1 commit into
mainfrom
webpack-noparse
May 14, 2026
Merged

fix(bundler-webpack): improve default value for module.noParse#1702
meteorlxy merged 1 commit into
mainfrom
webpack-noparse

Conversation

@Mister-Hope
Copy link
Copy Markdown
Member

@Mister-Hope Mister-Hope commented May 14, 2026

vuex is deprecated and the latest version is in 2021, people will prefer pinia if they want a state manager, but normally a docuementaion site do not need complex state managing.

Copilot AI review requested due to automatic review settings May 14, 2026 08:02
@coveralls
Copy link
Copy Markdown

coveralls commented May 14, 2026

Coverage Report for CI Build 25853781303

Coverage remained the same at 72.961%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1058
Covered Lines: 767
Line Coverage: 72.5%
Relevant Branches: 536
Covered Branches: 396
Branch Coverage: 73.88%
Branches in Coverage %: Yes
Coverage Strength: 45.84 hits per line

💛 - Coveralls

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the webpack bundler’s default module.noParse configuration for Vue-related packages.

Changes:

  • Replaces the previous anchored regexp with an array-based noParse configuration.
  • Removes explicit vuex and vuex-router-sync entries from the default no-parse list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/bundler-webpack/src/config/handleModule.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread packages/bundler-webpack/src/config/handleModule.ts Outdated
Comment thread packages/bundler-webpack/src/config/handleModule.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@meteorlxy meteorlxy merged commit 894ade0 into main May 14, 2026
22 checks passed
@meteorlxy meteorlxy deleted the webpack-noparse branch May 14, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants