Repository navigation
fix(types): add hotUpdateCallback to auto-resolver handleHotUpdate - #2836
Conversation
✅ Deploy Preview for vue-router canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe auto-resolver declaration adds an optional hot-update callback that receives the new resolver. TypeScript tests check the exported resolver type and callback signature. ChangesAuto-resolver types
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable issue remains in the supplied review evidence; this change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 78 78
Lines 6305 6305
Branches 2047 2047
=======================================
Hits 5566 5566
Misses 650 650
Partials 89 89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Declare the optional
hotUpdateCallbackthat the generatedvue-router/auto-resolvermodule already accepts and calls with the new resolver.Summary by CodeRabbit