Skip to content

build: fix tsdown output warnings - #2835

Merged
posva merged 1 commit into
mainfrom
build/no-warns
Oct 9, 2026
Merged

posva merged 1 commit into
mainfrom
build/no-warns

Conversation

@posva

@posva posva commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Use entryFileNames instead of file overrides to remove tsdown build warnings while preserving output file names.

Summary by CodeRabbit

  • Chores
    • Updated browser build output configuration; generated filenames remain unchanged.

@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 3456e77
🔍 Latest deploy log https://app.netlify.com/projects/vue-router/deploys/6ac8f582e93cea000871afc9

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: vuejs/router/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4117cd63-78ee-42b6-9723-9bc95e9a9c7e

📥 Commits

Reviewing files that changed from the base of the PR and between 2516f4e and 3456e77.


📒 Files selected for processing (1)
  • packages/router/tsdown.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The browser ESM, CommonJS, and IIFE build configurations now use entryFileNames instead of file. The output filenames remain unchanged and are specified relative to the build output directory.

Changes

Build output filenames

Layer / File(s) Summary
Configure output filenames
packages/router/tsdown.config.ts
The browser ESM, CommonJS, and IIFE configurations use entryFileNames for their regular and production outputs. The configured filenames remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor


Merge Risk: ⚪ Minimal · up to 3456e

The bundle filenames remain consistent with package metadata and repository consumers; no concrete merge-blocking behavior change is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the build configuration change and matches the stated objective of fixing tsdown output warnings.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/vue-router@2835
npm i https://pkg.pr.new/vue-router@2835
yarn add https://pkg.pr.new/vue-router@2835.tgz

commit: 3456e77

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.27%. Comparing base (6dec1f4) to head (3456e77).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2835   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          78       78           
  Lines        6305     6305           
  Branches     2070     2070           
=======================================
  Hits         5566     5566           
  Misses        650      650           
  Partials       89       89           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@posva
posva merged commit 8acc2bb into main Oct 9, 2026
11 checks passed
@posva
posva deleted the build/no-warns branch October 9, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant