Skip to content

Refactor how GraphicsPipelineCongfigurator::compare() handles the shaderHints->defines and descriptorConfigurator->defines together to avoid failure to match compatible configurations.#1697

Merged
robertosfield merged 1 commit intomasterfrom
GraphicsPipelineConfiguratorCompareFixes
Apr 16, 2026
Merged

Conversation

@robertosfield
Copy link
Copy Markdown
Collaborator

No description provided.

…aderHints->defines and descriptorConfigurator->defines together to avoid failure to match compatible configurations.
@robertosfield robertosfield merged commit f45b645 into master Apr 16, 2026
10 checks passed
@swp-ariaci
Copy link
Copy Markdown

This change appears to introduce a regression.

While testing the updated comparison logic, I ran into a crash in previously working code caused by dereferencing GraphicsPipelineConfigurator::descriptorConfigurator without a null check.

I’ve added a minimal reproducible example and details here:
#1682 (comment)

In short, descriptorConfigurator is accessed unconditionally in compare(), but it can be null in practice, which leads to a crash during SharedObjects::share(..., init).

It looks like a null check is needed before accessing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants