Repository navigation
Design win98: Keep the row checkboxes inside the table - #1377
Merged
Merged
Conversation
Adminer 6 renders the cells with the edit link and the row checkbox (td.hover) without borders on the basic background, so in win98 the first column of the select table lost its borders and the header checkbox cell lost the silver bevel of the other header cells. Restore the borders and backgrounds, including the odd rows, hovered and checked rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
The CI failure is unrelated to this change: phpcs flags |
Owner
Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Adminer 6, the cells with the edit link and the row checkbox (
td.hover) are rendered without borders on the basic background. In the win98 design this makes the first column of the select table lose its borders, and the header checkbox cell loses the silver bevel of the other header cells.This restores the borders and the backgrounds of these cells (including odd, hovered and checked rows), in the same way the removed
adminer-borderdesign did, plus the win98 header bevel.After:

Before:

Tested with Adminer 6.2.0 on a MySQL select page.
🤖 Generated with Claude Code