You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix value type check for select page value fields - #1355
Not sure what's the actual intention in the current code logic regarding values updates through select_value() plugins: to check if the modified value is numeric (current), or if the original value is numeric (proposed)? Plugins may transform 123 to <font ...>123</font> which works with current code but it may also transform it to 123 (some additional info) which doesn't work with current code. Or maybe check both modified and original values and allow any to be numeric??
class='number' means the cell is displayed as a number and should be aligned right. A description (Editor foreign keys, plugin select-foreign), Editor's yes/no for tinyint(1) or 123 (some additional info) is in a numeric column but isn't displayed as a number, and this change would align it right. color-for-column-type uses the class as a type marker instead. It could add its own class by the column type, like it already does for enum and datetime. Then the color doesn't depend on how another plugin formats the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what's the actual intention in the current code logic regarding values updates through
select_value()plugins: to check if the modified value is numeric (current), or if the original value is numeric (proposed)? Plugins may transform123to<font ...>123</font>which works with current code but it may also transform it to123 (some additional info)which doesn't work with current code. Or maybe check both modified and original values and allow any to be numeric??