Skip to content

Fix field null check in selectClick() - #1347

Closed
Shocker wants to merge 1 commit into
vrana:mainfrom
Shocker:field-null-check
Closed

Shocker wants to merge 1 commit into
vrana:mainfrom
Shocker:field-null-check

Conversation

@Shocker

@Shocker Shocker commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

I believe the current "is null field" check is not the best one and can trigger false-positives. Imagine a plugin setting some HTML data including an <i> tag using selectVal(&val, ...): this check would fail and consider the field being NULL due to the existance of an <i> tag, unrelated to actual NULL value. Instead, check for the hardcoded string <i>NULL</i> since this is also hardcoded in selectVal() @ https://github.com/vrana/adminer/blob/main/adminer/include/adminer.inc.php#L415

vrana added a commit that referenced this pull request Sep 28, 2026
Any <i> in the cell emptied the edited value, also a plugin's <i> in a non-NULL value.
Supersedes #1347 which doesn't match the highlighted NULL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vrana

vrana commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Thanks to #1344, I've solved this just by deleting code.

@vrana vrana closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants