Repository navigation
Conversation
vrana
added a commit
that referenced
this pull request
Sep 28, 2026
Any <i> in the cell emptied the edited value, also a plugin's <i> in a non-NULL value. Supersedes #1347 which doesn't match the highlighted NULL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks to #1344, I've solved this just by deleting code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the current "is null field" check is not the best one and can trigger false-positives. Imagine a plugin setting some HTML data including an
<i>tag usingselectVal(&val, ...): this check would fail and consider the field beingNULLdue to the existance of an<i>tag, unrelated to actual NULL value. Instead, check for the hardcoded string<i>NULL</i>since this is also hardcoded inselectVal()@ https://github.com/vrana/adminer/blob/main/adminer/include/adminer.inc.php#L415