Skip to content

Validate review reconnaissance envelopes before accepting child launches #295

Description

@tkstang

Problem

A final review launched two bounded reconnaissance children at the intended task classes. Both launches were accepted, then rejected incomplete envelopes before repository access. Because the children had already been accepted, replacement was unavailable and the primary reviewer had to repeat both evidence lanes inline.

The observable workflow failure is clear, but the exact missing fields were not retained, so the underlying envelope-construction cause remains unknown.

Proposed direction

  • Validate a child request against the selected role envelope before marking the launch accepted.
  • Return concrete missing-field diagnostics when validation fails.
  • Preserve the ability to correct or replace a request that never reached repository access.
  • Add regression coverage for both mechanical and intelligent reconnaissance lanes used by project review.

Acceptance criteria

  • An incomplete child envelope fails before accepted-launch state is recorded.
  • The failure identifies the missing or invalid fields.
  • A corrected or replacement launch remains possible.
  • Review workflows retain a durable terminal result for every accepted child.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tracked-in-backlogAccepted and linked to an OAT file-backed backlog item

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions