Skip to content

Fix semantic merge conflit in is_nan pushdown - #9984

Merged
robert3005 merged 1 commit into
developfrom
rk/fixbreak
Sep 22, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/fixbreak

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 22, 2026
@robert3005
robert3005 enabled auto-merge (squash) September 22, 2026 17:42
@codspeed

codspeed Bot commented Sep 22, 2026

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 2202 untouched benchmarks
⏩ 293 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation take_fsl_u32_random[256, 10] 124.4 µs 159 µs -21.74%
❌ WallTime dict_canonicalize_gt_u8_neon[1000000] 488.3 µs 547.8 µs -10.86%
⚡ Simulation take_fsl_f16_random[16, 100] 176.9 µs 118.4 µs +49.46%
⚡ WallTime filtered_sink_i64_avx512[OneNullInEight] 26.5 µs 22.3 µs +18.83%
⚡ Simulation take_fsl_u8_random[256, 100] 182.7 µs 156.3 µs +16.86%
⚡ Simulation take_fsl_nullable_random[16, 100] 187.7 µs 164.2 µs +14.32%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/fixbreak (55e8980) with develop (00a0ccc)2

Open in CodSpeed

Footnotes

  1. 293 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (2919b50) during the generation of this report, so 00a0ccc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@robert3005
robert3005 merged commit 133aacd into develop Sep 22, 2026
109 of 111 checks passed
@robert3005
robert3005 deleted the rk/fixbreak branch September 22, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants