Skip to content

Perform fixed width array operations in type width units instead of byte units - #9824

Open
robert3005 wants to merge 3 commits into
developfrom
rk/fixedwidtht
Open

robert3005 wants to merge 3 commits into
developfrom
rk/fixedwidtht

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Instead of doing all offset calculation in byte units we do them in type T units
which is less errorprone


Stack created with GitHub Stacks CLI • Give Feedback 💬

@robert3005
robert3005 added this pull request to stack #9825 September 10, 2026 00:37
@codspeed

codspeed Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.52%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 2096 untouched benchmarks
⏩ 503 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation random_i256[0.8] 124.7 µs 144.2 µs -13.52%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/fixedwidtht (d9a8f6a) with develop (900c1f2)

Open in CodSpeed

Footnotes

  1. 503 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005 robert3005 added the changelog/chore A trivial change label Sep 11, 2026
@robert3005
robert3005 marked this pull request as ready for review September 11, 2026 10:29
Base automatically changed from rk/uninitwriteslice to develop September 15, 2026 22:56
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Oct 1, 2026
…yte units

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 removed the stale This PR is stale and will be auto-closed soon label Oct 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant