Repository navigation
Replace MaybeUninit transmutes with write_copy_of_slice - #9814
Conversation
Merging this PR will degrade performance by 8.7%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | arrow_checked_add_u32_neon[16384] |
13.5 µs | 20.3 µs | -33.53% |
| ❌ | Simulation | random_i8[0.5] |
71.3 µs | 94.9 µs | -24.81% |
| ❌ | Simulation | decompress[u64, (4000, 1024)] |
71.5 µs | 86.1 µs | -16.89% |
| ❌ | WallTime | filtered_sink_i64_avx2[NineNullsInTen] |
15.7 µs | 18 µs | -12.61% |
| ❌ | Simulation | patterns_i128[Runs] |
109.8 µs | 124.3 µs | -11.61% |
| ❌ | WallTime | filtered_owned_i64_avx2[NineNullsInTen] |
13.3 µs | 15 µs | -11.4% |
| ❌ | Simulation | random_i128[0.8] |
174.3 µs | 196.2 µs | -11.16% |
| ⚡ | Simulation | random_i16[0.8] |
96.4 µs | 78 µs | +23.64% |
| ⚡ | WallTime | words_gather_scalar_avx2[65536] |
9.4 µs | 8.3 µs | +13.64% |
| ⚡ | Simulation | allocate_drop_arrow[0] |
456.9 ns | 402.7 ns | +13.45% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/uninitwriteslice (51f1041) with develop (b5f43ba)
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
ee0fda0 to
2720cef
Compare
2720cef to
51f1041
Compare
This also fixes a bug in BufferMut where extend_from_slice copied non copy types
Signed-off-by: Robert Kruszewski github@robertk.io