Skip to content

Replace MaybeUninit transmutes with write_copy_of_slice - #9814

Merged
robert3005 merged 3 commits into
developfrom
rk/uninitwriteslice
Sep 15, 2026
Merged

robert3005 merged 3 commits into
developfrom
rk/uninitwriteslice

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This also fixes a bug in BufferMut where extend_from_slice copied non copy types

Signed-off-by: Robert Kruszewski github@robertk.io

Comment thread vortex-array/src/arrays/fixed_width/take/slices.rs
@codspeed

codspeed Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.7%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 7 regressed benchmarks
✅ 2188 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime arrow_checked_add_u32_neon[16384] 13.5 µs 20.3 µs -33.53%
❌ Simulation random_i8[0.5] 71.3 µs 94.9 µs -24.81%
❌ Simulation decompress[u64, (4000, 1024)] 71.5 µs 86.1 µs -16.89%
❌ WallTime filtered_sink_i64_avx2[NineNullsInTen] 15.7 µs 18 µs -12.61%
❌ Simulation patterns_i128[Runs] 109.8 µs 124.3 µs -11.61%
❌ WallTime filtered_owned_i64_avx2[NineNullsInTen] 13.3 µs 15 µs -11.4%
❌ Simulation random_i128[0.8] 174.3 µs 196.2 µs -11.16%
⚡ Simulation random_i16[0.8] 96.4 µs 78 µs +23.64%
⚡ WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.3 µs +13.64%
⚡ Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/uninitwriteslice (51f1041) with develop (b5f43ba)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread vortex-buffer/src/buffer_mut.rs Outdated
Comment thread vortex-buffer/src/buffer_mut.rs Outdated
@robert3005
robert3005 added this pull request to stack #9825 September 10, 2026 00:37

@AdamGS AdamGS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit c4561ac into develop Sep 15, 2026
112 of 114 checks passed
@robert3005
robert3005 deleted the rk/uninitwriteslice branch September 15, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants