Skip to content

Test IO file sizes in Rust and array sizes in Python doctests - #9792

Open
robert3005 wants to merge 2 commits into
developfrom
rk/python-io-doctest-size
Open

robert3005 wants to merge 2 commits into
developfrom
rk/python-io-doctest-size

Conversation

@robert3005

@robert3005 robert3005 commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Python io doc tests check compressed size in bytes since that's what they're talking about. Keep the file size test as a rust test

@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from e1cf626 to 8bb4130 Compare September 8, 2026 11:13
@codspeed

codspeed Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 10.74%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 2110 untouched benchmarks
⏩ 518 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime words_gather_dispatch_neon[65536] 2.3 µs 2 µs +10.74%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/python-io-doctest-size (9a58a45) with develop (f234bc6)

Open in CodSpeed

Footnotes

  1. 518 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005 robert3005 added changelog/docs A docs change changelog/chore A trivial change and removed changelog/docs A docs change labels Sep 8, 2026
@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from 8bb4130 to d6147dd Compare September 8, 2026 11:23

@joseph-isaacs joseph-isaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into a rust test on the written file size. It really useful to know when we change file size

@robert3005 robert3005 changed the title Python io doctests assert on nbytes not on the file size Test IO file sizes in Rust and array sizes in Python doctests Sep 8, 2026
@robert3005

Copy link
Copy Markdown
Contributor Author

Here you go, there's a rust test now, I kept the python change since this is useful for docs

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Oct 1, 2026
@robert3005 robert3005 removed the stale This PR is stale and will be auto-closed soon label Oct 7, 2026
@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from c0aae71 to db43544 Compare October 7, 2026 11:18
@robert3005
robert3005 enabled auto-merge (squash) October 7, 2026 11:18
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from db43544 to 9a58a45 Compare October 7, 2026 12:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants