Skip to content

Simplify StatsRewriteCtx rules by leveraging BoundExpressions - #9643

Merged
robert3005 merged 5 commits into
developfrom
rk/boundstatsrewrite
Sep 22, 2026
Merged

robert3005 merged 5 commits into
developfrom
rk/boundstatsrewrite

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Since we have BoundExpressions we don't have to go through the StatsRewriteCtx
to resolve the dtype anymore

@robert3005 robert3005 added the changelog/chore A trivial change label Aug 26, 2026
@robert3005
robert3005 enabled auto-merge (squash) August 26, 2026 16:57
@codspeed

codspeed Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.75%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 6 regressed benchmarks
✅ 2198 untouched benchmarks
⏩ 293 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decode_primitives[f32, (1000, 512)] 42 µs 64.6 µs -34.97%
❌ Simulation take_fsl_f16_random[16, 100] 119.4 µs 176.8 µs -32.48%
❌ WallTime dbp_assemble_kernel_avx512[(I128, 1024)] 467 ns 555 ns -15.86%
❌ Simulation take_fsl_u8_random[256, 100] 157.4 µs 182.4 µs -13.74%
❌ Simulation take_fsl_nullable_random[16, 100] 165.6 µs 187.6 µs -11.71%
❌ WallTime dict_canonicalize_gt_u8_neon[1000000] 489.5 µs 548 µs -10.68%
⚡ Simulation take_fsl_u32_random[256, 10] 159.4 µs 124.4 µs +28.19%
⚡ WallTime filtered_sink_i64_avx2[OneNullInEight] 26.1 µs 21.9 µs +19.3%
⚡ WallTime filtered_sink_i64_avx512[OneNullInEight] 26.5 µs 22.5 µs +17.46%
⚡ Simulation take_fsl_random[128, 10] 139.4 µs 126.6 µs +10.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/boundstatsrewrite (8137cbd) with develop (24d67e8)

Open in CodSpeed

Footnotes

  1. 293 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 merged commit 5c1671e into develop Sep 22, 2026
86 of 87 checks passed
@robert3005
robert3005 deleted the rk/boundstatsrewrite branch September 22, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants