Skip to content

duckdb: support windows-x86 and windows-arm64 - #9570

Merged
myrrc merged 6 commits into
developfrom
myrrc/duckdb-win
Oct 28, 2026
Merged

myrrc merged 6 commits into
developfrom
myrrc/duckdb-win

Conversation

@myrrc

@myrrc myrrc commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor
  • Support building and linking vortex-duckdb from Windows.
  • Run vortex-sqllogictest and vortex-duckdb tests in CI for Windows-x64.
  • Use url.to_file_path() instead of url.path() which produces a leading slash (/C:/...) on Windows.
  • Remove -fno-gnu-unique since it's obsolete for duckdb 2.0's C++17.
  • Fix sqllogic tests error messages to be working for Windows
  • Replace back slashes with forward slashes in sqllogic test runner as duckdb produces paths with forward slashes in output.
  • Fix spatial tests concurrently loading spatial extension, run tests sequentially

@myrrc myrrc linked an issue Aug 24, 2026 that may be closed by this pull request
2 of 4 tasks
@myrrc myrrc added changelog/feature A new feature ext/duckdb Relates to the DuckDB integration labels Aug 24, 2026
@codspeed

codspeed Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

3 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2201 untouched benchmarks
⏩ 370 skipped benchmarks1
🗄️ 30 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime lt_i64_nullable_avx2 8.3 µs 9.5 µs -12.21%
⚡ CPU Simulation test_scan_scalar_at[int_str] 1,015.3 µs 884.2 µs +14.82%
⚡ CPU Simulation test_repeated_scan_scalar_at[int_str] 386.8 µs 339.4 µs +13.97%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-win (beda46c) with develop (9c12160)

Open in CodSpeed

Footnotes

  1. 370 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 30 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Sep 10, 2026
@myrrc myrrc removed the stale This PR is stale and will be auto-closed soon label Sep 10, 2026
@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Sep 28, 2026
@myrrc myrrc removed the stale This PR is stale and will be auto-closed soon label Sep 29, 2026
@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Oct 15, 2026
@github-actions github-actions Bot closed this Oct 22, 2026
@myrrc myrrc reopened this Oct 26, 2026
@myrrc
myrrc deployed to duckdb-build October 27, 2026 15:57 — with GitHub Actions Active
@myrrc
myrrc deployed to duckdb-build October 27, 2026 15:57 — with GitHub Actions Active
@myrrc myrrc removed the stale This PR is stale and will be auto-closed soon label Oct 27, 2026
@myrrc
myrrc deployed to duckdb-build October 27, 2026 16:16 — with GitHub Actions Active
@myrrc
myrrc deployed to duckdb-build October 27, 2026 16:16 — with GitHub Actions Active
myrrc added 2 commits October 27, 2026 16:40
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc deployed to duckdb-build October 27, 2026 17:04 — with GitHub Actions Active
@myrrc
myrrc deployed to duckdb-build October 27, 2026 17:04 — with GitHub Actions Active
@myrrc myrrc changed the title Duckdb Windows support duckdb: support windows-x86 Oct 27, 2026
@myrrc myrrc changed the title duckdb: support windows-x86 duckdb: support windows-x86 and windows-arm64 Oct 28, 2026
@vortex-data vortex-data deleted a comment from github-actions Bot Oct 28, 2026
@vortex-data vortex-data deleted a comment from github-actions Bot Oct 28, 2026
@vortex-data vortex-data deleted a comment from github-actions Bot Oct 28, 2026
@vortex-data vortex-data deleted a comment from github-actions Bot Oct 28, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc requested a review from robert3005 October 28, 2026 11:55
@myrrc
myrrc marked this pull request as ready for review October 28, 2026 11:55
@myrrc
myrrc requested a review from 0ax1 October 28, 2026 11:56
myrrc added 2 commits October 28, 2026 12:15
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@github-actions
github-actions Bot temporarily deployed to docs-preview/pr-9570 October 28, 2026 13:27 Inactive
@myrrc
myrrc enabled auto-merge (squash) October 28, 2026 13:27

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have windows dedicated sql logic tests

@myrrc
myrrc disabled auto-merge October 28, 2026 14:15
@myrrc
myrrc merged commit 10f084b into develop Oct 28, 2026
85 of 86 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-win branch October 28, 2026 14:15

This branch was successfully deployed

1 active (outdated) and 1 inactive deployments
docs-preview/pr-9570 — beda46c7 Deployed Oct 28, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duckdb Windows support

2 participants