Repository navigation
test(spark): characterize VortexTable capabilities and builders - #9160
Merged
robert3005 merged 1 commit intoAug 4, 2026
Merged
Conversation
VortexTable had no unit tests. Pin the table-level contract Spark relies on: the exact capability set, how the name is rendered from the table paths, that schema and partitioning round-trip unchanged, and that the scan builder starts from the full table schema. Also cover the write-path guard. Writes target a single output path, so newWriteBuilder goes through Iterables.getOnlyElement and rejects tables built from several paths, or none. Signed-off-by: jackylee <qcsd2011@gmail.com>
robert3005
enabled auto-merge (squash)
August 4, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VortexTablehad no unit tests. This pins the table-level contract Spark relies on, in the same style as the recentVortexBatchExecandHadoopUtilscharacterization tests.Covered:
BATCH_READ,BATCH_WRITE,TRUNCATE)name()renders from the table paths, for one path and severalschema()andpartitioning()round-tripping unchangednewScanBuilderstarting from the full table schema, and the scan description carrying every pathnewWriteBuildergoes throughIterables.getOnlyElementand rejects a table built from several paths (IllegalArgumentException) or none (NoSuchElementException)Pure JVM unit tests, no
SparkSessionand no filesystem access.Tests
./gradlew :vortex-spark_2.13:test --tests 'dev.vortex.spark.VortexTableTest'— 8/8 pass./gradlew :vortex-spark_2.12:test --tests 'dev.vortex.spark.VortexTableTest'— 8/8 pass./gradlew :vortex-spark_2.13:spotlessCheck— clean./gradlew javadoc— clean