Skip to content

CI: build benchmarks binaries once for all targets #9121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myrrc merged 1 commit into from
Jul 31, 2026
Merged

CI: build benchmarks binaries once for all targets #9121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 61 additions & 22 deletions .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,61 @@ jobs:
matrix="$(uv run --project bench-orchestrator vx-bench matrix "$MATRIX_PRESET")"
echo "benchmark_matrix=$matrix" >> "$GITHUB_OUTPUT"

build:
timeout-minutes: 60
env:
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"

@AdamGS AdamGS Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are runtime only, should be OK to remove here

FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
&& format('runs-on={0}/runner=bench-dedicated/family={1}/tag=build{2}', github.run_id, inputs.machine_type, (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && '/extras=s3-cache' || '')
|| 'ubuntu-latest' }}
steps:
- uses: runs-on/action@v2
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
with:
sccache: s3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
ref: ${{ inputs.mode == 'pr' && github.event.pull_request.head.sha || github.sha }}
- uses: ./.github/actions/setup-rust
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
enable-sccache: ${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && 'true' || 'false' }}
- name: Build binaries
shell: bash
env:
RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
run: |
packages=(--bin data-gen --bin datafusion-bench --bin duckdb-bench)
if [ "${{ inputs.mode }}" != "pr" ]; then
packages+=(--bin lance-bench)
fi
cargo build "${packages[@]}" --profile release_debug --features unstable_encodings
- name: Upload binaries
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: bench-binaries
path: |
target/release_debug/data-gen
target/release_debug/datafusion-bench
target/release_debug/duckdb-bench
target/release_debug/lance-bench
target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so
- name: Pre-upload SQL benchmark debuginfo to Polar Signals
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
uses: ./.github/actions/upload-parca-debuginfo
continue-on-error: true
with:
paths: |
target/release_debug/datafusion-bench
target/release_debug/duckdb-bench
${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }}
polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56"

bench:
needs: resolve-matrix
needs: [resolve-matrix, build]
timeout-minutes: 120
env:
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
Expand Down Expand Up @@ -85,28 +138,14 @@ jobs:

- uses: ./.github/actions/system-info

- name: Build binaries
shell: bash
env:
RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
run: |
packages=(--bin data-gen --bin datafusion-bench --bin duckdb-bench)
if [ "${{ inputs.mode }}" != "pr" ]; then
packages+=(--bin lance-bench)
fi
cargo build "${packages[@]}" --profile release_debug --features unstable_encodings

- name: Pre-upload SQL benchmark debuginfo to Polar Signals
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
uses: ./.github/actions/upload-parca-debuginfo
continue-on-error: true
- name: Download binaries
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
paths: |
target/release_debug/datafusion-bench
target/release_debug/duckdb-bench
${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }}
polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56"
name: bench-binaries
path: target/release_debug/
- name: Make binaries executable
shell: bash
run: chmod +x target/release_debug/*

- name: Generate data
shell: bash
Expand Down
Loading