Repository navigation
Add canonical Map arrays and builder - #9108
Merged
Merged
Conversation
Merging this PR will improve performance by 14.39%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
AdamGS
force-pushed
the
adamg/maptype-2
branch
2 times, most recently
from
July 31, 2026 13:17
b158bfe to
bc1872e
Compare
robert3005
reviewed
Aug 4, 2026
| builder: &mut dyn ArrayBuilder, | ||
| ctx: &mut ExecutionCtx, | ||
| ) -> VortexResult<()> { | ||
| builder.append_map_array(array, ctx) |
Contributor
There was a problem hiding this comment.
downcast the builder here
robert3005
reviewed
Aug 4, 2026
| /// | ||
| /// Only map-typed builders support this; canonical map arrays dispatch through this hook so | ||
| /// the generic offset and size types of their nested list-view builders stay erased. | ||
| fn append_map_array( |
Contributor
There was a problem hiding this comment.
If you rebase the listview/list array methods are gone
AdamGS
force-pushed
the
adamg/maptype-2
branch
3 times, most recently
from
August 4, 2026 12:38
1ff6f07 to
364b5d2
Compare
AdamGS
marked this pull request as ready for review
August 4, 2026 14:48
robert3005
approved these changes
Aug 4, 2026
AdamGS
added a commit
that referenced
this pull request
Aug 4, 2026
## Rationale for this change Vortex currently has no native logical map type, so Arrow maps must be represented as lists of structs and lose map-specific semantics such as non-null keys and the `keys_sorted` assertion. This provides the type-level foundation for native Map support; #9108 builds on it with canonical arrays and builders. Related to #428. ## What changes are included in this PR? - Adds `DType::Map` and `MapDType`, including key/value dtypes, outer nullability, sortedness, validation, coercion, display, equality, and hashing. - Adds map scalar construction and typed access through `Scalar::map`, `Scalar::try_map`, and `MapScalar`. - Adds map dtype and scalar serialization through Serde, Protobuf, and FlatBuffers. - Adds Arrow dtype/schema round-tripping, Vortex-to-Arrow map scalar conversion, and DataFusion physical-schema reconciliation. - Tests cover dtype and scalar validation, null and empty maps, coercion, serialization round-trips, Arrow schema conversion, and nested extension metadata. ## What APIs are changed? Are there any user-facing changes? This adds the public `DType::Map` and `ScalarValue::Map` variants, `MapDType`, `MapScalar`, and their constructors and accessors. Consumers that exhaustively match `DType` or `ScalarValue` must handle the new variants. The Protobuf and FlatBuffers dtype schemas also gain Map variants. This PR supports Map dtypes, schemas, and scalars, but not full Arrow `MapArray` transport. Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Building on the logical type and scalar support in #9107, this makes map-typed arrays constructible, canonicalizable, and serializable. A dedicated canonical representation preserves Map semantics instead of treating maps as ordinary lists of structs.
What changes are included in this PR?
vortex.mapcanonical encoding, backed byListView<Struct<key, value>>storage while retaining the Map dtype andkeys_sortedassertion.MapArray, validated construction, entry access, validity delegation, scalar access, serialization, and session registration.MapBuilderand integrates Map values with generic builder and canonicalization paths, including empty, constant, and chunked arrays.What APIs are changed? Are there any user-facing changes?
This adds the public
Map,MapArray,MapArrayExt,MapDataParts, andMapBuilderAPIs.CanonicalandCanonicalViewgain Map variants and corresponding accessors, so exhaustive matches over those enums must handle Map arrays.Map arrays can now be built, canonicalized, inspected, and serialized. Compute paths such as take, filter, masking, compression, and Arrow array transport continue to reject Map arrays at this point in the stack.