Skip to content

fix: avoid ListView take_reduce rebuild for dense selections - #7339

Merged
joseph-isaacs merged 9 commits into
developfrom
mitko/avoid-list-view-take-reduce-rebuild
Apr 16, 2026
Merged

joseph-isaacs merged 9 commits into
developfrom
mitko/avoid-list-view-take-reduce-rebuild

refactor: move listview rebuild density threshold to compute mod

2eb3db2
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis succeeded Apr 16, 2026 in 0s

Performance Gate Passed

⚡ 9 improved benchmarks
✅ 1154 untouched benchmarks
⏩ 1457 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation take_map[(0.1, 0.5)] 1,154.5 µs 970.7 µs +18.94%
⚡ Simulation take_map[(0.1, 1.0)] 2 ms 1.6 ms +20.23%
⚡ Simulation patched_take_10k_contiguous_not_patches 258.4 µs 228.2 µs +13.25%
⚡ Simulation patched_take_10k_contiguous_patches 258.1 µs 227.8 µs +13.27%
⚡ Simulation patched_take_10k_dispersed 316 µs 285.8 µs +10.56%
⚡ Simulation patched_take_10k_first_chunk_only 302 µs 271.7 µs +11.15%
⚡ Simulation patched_take_10k_random 270.3 µs 240 µs +12.63%
⚡ Simulation take_10k_dispersed 284.4 µs 239.5 µs +18.75%
⚡ Simulation take_10k_first_chunk_only 270.6 µs 225.6 µs +19.91%

Comparing mitko/avoid-list-view-take-reduce-rebuild (2eb3db2) with develop (01679cd)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩