Skip to content

Do we need to explicitly install ninja? - #7310

Merged
robert3005 merged 2 commits into
developfrom
rk/noninja
Apr 7, 2026
Merged

robert3005 merged 2 commits into
developfrom
rk/noninja

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This is likely preinstalled

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Apr 7, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@0ax1
0ax1 self-requested a review April 7, 2026 11:14
@joseph-isaacs

Copy link
Copy Markdown
Contributor

You can also check in the prebuild

@robert3005
robert3005 enabled auto-merge (squash) April 7, 2026 11:15
@codspeed

codspeed Bot commented Apr 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 19.94%

⚡ 1 improved benchmark
✅ 1121 untouched benchmarks
⏩ 1530 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation chunked_bool_canonical_into[(1000, 10)] 60 µs 50.1 µs +19.94%

Comparing rk/noninja (87afdba) with develop (613638a)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit b0cf87b into develop Apr 7, 2026
59 checks passed
@robert3005
robert3005 deleted the rk/noninja branch April 7, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants