Skip to content

Derive live statistics proofs for dynamic expressions - #10869

Merged
gatesn merged 1 commit into
developfrom
ngates/dynamic-expression-statistics
Oct 27, 2026
Merged

gatesn merged 1 commit into
developfrom
ngates/dynamic-expression-statistics

Conversation

@gatesn

@gatesn gatesn commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Extract generic dynamic predicate falsification from #10665. Keep proofs live across predicate generations and conservatively retain rows when a proof or required statistic is unavailable.

@gatesn gatesn added the changelog/feature A new feature label Oct 27, 2026
@gatesn
gatesn marked this pull request as ready for review October 27, 2026 16:14
@gatesn
gatesn enabled auto-merge (squash) October 27, 2026 16:14
@codspeed

codspeed Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.3%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 2199 untouched benchmarks
⏩ 370 skipped benchmarks1
🗄️ 30 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime filter_neon[64] 1.8 µs 2.4 µs -25.62%
❌ Walltime threshold_neon[64] 2.6 µs 3.1 µs -18.26%
❌ Walltime filter_neon[80] 2.5 µs 3.1 µs -16.6%
⚡ CPU Simulation missing_stats[16] 88.5 µs 71 µs +24.56%
⚡ Walltime threshold_avx2[80] 3 µs 2.6 µs +14.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/dynamic-expression-statistics (646c5df) with develop (bdae6a7)

Open in CodSpeed

Footnotes

  1. 370 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 30 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

Extract generic dynamic predicate truth and falsity proofs from #10665. Keep proofs live across predicate generations and conservatively prove nothing when a proof or required statistic is unavailable.

Co-authored-by: Robert Kruszewski <github@robertk.io>

Source: #10665 (19a26fd)
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/dynamic-expression-statistics branch from dbfc076 to 646c5df Compare October 27, 2026 16:24
@gatesn
gatesn merged commit 088118b into develop Oct 27, 2026
80 checks passed
@gatesn
gatesn deleted the ngates/dynamic-expression-statistics branch October 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants