Repository navigation
Make protobuf metadata fields crate-private - #10831
Conversation
Merging this PR will degrade performance by 49.03%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
166712e to
13e3be2
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
13e3be2 to
68d9f68
Compare
Depends on #10755.
Summary
Public metadata fields expose the stored layout as Rust API and let callers bypass typed accessors. Restrict them to the owning crate while preserving the encoded metadata.
Changes
Add getters for CUDA’s Zstd metadata and a constructor and CRS getter for spatial callers. The TUI uses the existing flat-layout accessor. Internal struct literals and metadata golden files stay unchanged.
Formatting and clippy passed. Tests passed apart from
chunked_input_with_mixed_dimensions_returns_error, which fails identically on the base. GPU tests were skipped withoutnvcc.API Changes
Metadata fields are now
pub(crate). Direct field access and struct literals from other crates no longer compile.