Repository navigation
fix(layout): stop dict writer looping on an oversized value - #10400
Merged
Merged
Conversation
A value too large to fit an empty dictionary made BytesDictBuilder and PrimitiveDictBuilder encode 0 rows, so DictStreamState::encode retried the same chunk forever while pushing empty chunks into its result vector. Guarantee forward progress by always admitting the first entry into an empty dictionary, even when it exceeds the byte or length budget. An oversized value is then written as its own single-entry dictionary and encoding terminates. Fixes #10397 Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Robert Kruszewski <robert3005@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
changed the title
robert3005
approved these changes
Oct 9, 2026
joseph-isaacs
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10397
A value larger than the dictionary byte budget did not fit an empty dictionary. The encoder then encoded 0 rows, and
DictStreamState::encoderetried the same chunk forever.The bytes and primitive dictionary builders now always admit the first entry, so each encode step makes progress.