Repository navigation
fix(python): translate Polars is_null expressions - #10189
Conversation
7305d19 to
56a3e63
Compare
Merging this PR will degrade performance by 15.16%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | density_sweep_dense_runs[0.001] |
30.3 µs | 48 µs | -36.94% |
| ⚡ | WallTime | bitpack_blocked_compress_avx2 |
7.6 µs | 6.6 µs | +14.15% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing dk/polars-is-null (61b090a) with develop (fdfe7f4)2
Footnotes
-
534 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(4ba858a) during the generation of this report, so fdfe7f4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Signed-off-by: Daniel King <dan@spiraldb.com>
56a3e63 to
61b090a
Compare
Polars
is_null()fails predicate conversion despite native Vortex support. Map the Boolean.IsNull function directly tove.is_null, including null input rows.This is a direct expression translation; it performs no eager evaluation and does not require literal arguments. Literal-specific PRs decode the scalar representation itself.
Validation: 1 targeted regression case(s) passed with this PR’s converter. With only
polars_.pyrestored to the base revision and the same tests retained, all 1 failed with PolarsComputeErrorwrapping the unsupported-expressionValueErrororNotImplementedError. The tests compare complete dataframes from Polars alone and a Vortex-backed Polars scan, and check explicit row expectations. No lint or broader suite was run.