Skip to content

fix(python): translate Polars is_null expressions - #10189

Merged
robert3005 merged 1 commit into
developfrom
dk/polars-is-null
Oct 8, 2026
Merged

robert3005 merged 1 commit into
developfrom
dk/polars-is-null

Conversation

@danking

@danking danking commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Polars is_null() fails predicate conversion despite native Vortex support. Map the Boolean.IsNull function directly to ve.is_null, including null input rows.

This is a direct expression translation; it performs no eager evaluation and does not require literal arguments. Literal-specific PRs decode the scalar representation itself.

Validation: 1 targeted regression case(s) passed with this PR’s converter. With only polars_.py restored to the base revision and the same tests retained, all 1 failed with Polars ComputeError wrapping the unsupported-expression ValueError or NotImplementedError. The tests compare complete dataframes from Polars alone and a Vortex-backed Polars scan, and check explicit row expectations. No lint or broader suite was run.

@danking danking added the changelog/fix A bug fix label Oct 1, 2026
@danking
danking marked this pull request as ready for review October 1, 2026 17:59
@codspeed

codspeed Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 15.16%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 2173 untouched benchmarks
⏩ 534 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation density_sweep_dense_runs[0.001] 30.3 µs 48 µs -36.94%
⚡ WallTime bitpack_blocked_compress_avx2 7.6 µs 6.6 µs +14.15%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dk/polars-is-null (61b090a) with develop (fdfe7f4)2

Open in CodSpeed

Footnotes

  1. 534 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (4ba858a) during the generation of this report, so fdfe7f4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@robert3005
robert3005 enabled auto-merge (squash) October 8, 2026 22:13
Signed-off-by: Daniel King <dan@spiraldb.com>
@robert3005
robert3005 merged commit 4895bd4 into develop Oct 8, 2026
86 of 87 checks passed
@robert3005
robert3005 deleted the dk/polars-is-null branch October 8, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants