Repository navigation
fix(python): translate Polars binary scalar literals - #10188
Conversation
027ea41 to
200e872
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
200e872 to
d6cf0f4
Compare
Merging this PR will degrade performance by 10.6%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | bitpack_blocked_compress_avx2 |
6.8 µs | 7.6 µs | -10.6% |
| Simulation | bench_compare_primitive[(10000, 2)] |
< 1 ns | < 1 ns | N/A |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing dk/polars-binary-literals (d6cf0f4) with develop (9593b60)2
Footnotes
-
534 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(fdfe7f4) during the generation of this report, so 9593b60 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Polars serializes binary scalar literals as integer byte arrays. Decode those bytes and create a native Vortex binary literal; passing the JSON integer list as the literal value is incorrect.
This is a direct expression translation; it performs no eager evaluation and does not require literal arguments. Literal-specific PRs decode the scalar representation itself.
Validation: 1 targeted regression case(s) passed with this PR’s converter. With only
polars_.pyrestored to the base revision and the same tests retained, all 1 failed with PolarsComputeErrorwrapping the unsupported-expressionValueErrororNotImplementedError. The tests compare complete dataframes from Polars alone and a Vortex-backed Polars scan, and check explicit row expectations. No lint or broader suite was run.