Repository navigation
fix(python): support unsigned Polars scalar literals - #10170
Conversation
bd883a7 to
f8b4255
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E92wUoS3LaqWVJmmS7vKVq
4d23c19 to
092e50d
Compare
Merging this PR will improve performance by 12.86%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | bitpack_blocked_compress_avx2 |
7.6 µs | 6.7 µs | +12.86% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing dk/polars-predicate-pushdown (092e50d) with develop (c93ffa3)2
Footnotes
-
534 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(293d4f7) during the generation of this report, so c93ffa3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Polars predicate pushdown can serialize unsigned comparison literals as typed scalar variants that the converter rejects. Decode recognized scalar variants through the existing literal type mapping, including UInt8, UInt16, UInt32, and UInt64.
Add file-scan regression cases for comparisons on all four unsigned widths. Split from the original combined PR; datetime changes are in #10183 (stacked on #10182), and
is_not_nullchanges are in #10184.Validation: 4 targeted regression case(s) passed with this PR’s converter. With only
polars_.pyrestored to the base revision and the same tests retained, all 4 failed with PolarsComputeErrorwrapping the unsupported-expressionValueErrororNotImplementedError. The tests compare complete dataframes from Polars alone and a Vortex-backed Polars scan, and check explicit row expectations. No lint or broader suite was run.