Spring refactor integration - #49
Open
Albireo-B wants to merge 1 commit into
Open
Annotations
6 errors and 12 warnings
|
Maven
Process completed with exit code 1.
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/workflowsdb/WorkflowsDBRepository.java#L33
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/runner/MoteurLiteRunner.java#L31
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/runner/JobSubmitter.java#L26
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/runner/InputsFileService.java#L18
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/gasw/Monitor.java#L21
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-java@v3, pmd/pmd-github-action@v2. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Maven
Cannot build an overlay database because build-mode is set to "undefined" instead of "none". Falling back to creating a normal full database instead.
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLiteException.java#L4
Reports method and constructor parameters that can be made final because they are never reassigned within the body of the method.
This rule ignores unused parameters so as not to overlap with the rule {% rule java/bestpractices/UnusedFormalParameter %}.
It will also ignore the parameters of abstract methods.
MethodArgumentCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#methodargumentcouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLiteConstants.java#L3
A class is a utility class, if and only if it fulfills ALL the following criteria:
* ALL member functions, member variables, nested classes, and initializers are static.
* The class has at least one member function, member variable, or nested class that is not private.
* The class is a concrete class (neither abstract nor an interface).
* The class has no superclasses and implements no interfaces.
* The class has no main method.
Utility classes should not be instantiable. Make sure that the only constructor is a
private no-args constructor to enforce this.
(Note, that this rule was known before PMD 5.1.0 as UseSingleton).
UseUtilityClass (Priority: 3, Ruleset: Design)
https://docs.pmd-code.org/snapshot/pmd_rules_java_design.html#useutilityclass
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLiteConfiguration.java#L16
A local variable assigned only once can be declared final.
LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLiteConfiguration.java#L11
Fields, formal arguments, or local variable names that are too long can make the code difficult to follow.
LongVariable (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#longvariable
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L13
Avoid negation within an "if" expression with an "else" clause. For example, rephrase:
`if (x != y) diff(); else same();` as: `if (x == y) same(); else diff();`.
Most "if (x != y)" cases without an "else" are often return cases, so consistent use of this
rule makes the code easier to read. Also, this resolves trivial ordering problems, such
as "does the error case go first?" or "does the common case go first?".
Since null checks are commonly considered a positive condition, they are by default ignored
by this rule. This means both `a == null` and `a != null` are allowed. If you want
to enforce either style and disallow the other, use the property `nullCheckBranch`.
ConfusingTernary (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#confusingternary
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L11
Avoid negation within an "if" expression with an "else" clause. For example, rephrase:
`if (x != y) diff(); else same();` as: `if (x == y) same(); else diff();`.
Most "if (x != y)" cases without an "else" are often return cases, so consistent use of this
rule makes the code easier to read. Also, this resolves trivial ordering problems, such
as "does the error case go first?" or "does the common case go first?".
Since null checks are commonly considered a positive condition, they are by default ignored
by this rule. This means both `a == null` and `a != null` are allowed. If you want
to enforce either style and disallow the other, use the property `nullCheckBranch`.
ConfusingTernary (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#confusingternary
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L9
Checking the length of `string.trim()` or `string.strip()` is an inefficient way
to decide if a string is really blank, as it creates a new `String` object just to check its size.
As of Java 11 you can use `string.isBlank()` to decide if a string consists only of whitespace,
that check is equivalent to `string.strip().isEmpty()`. To get the semantic of
`string.trim().isEmpty()`, you can loop through the characters and compare them to 0x20:
```java
private boolean checkTrimEmpty(String str) {
return str.chars().allMatch(c -> c <= 0x20);
}
```
You can also consider using library functions that include a null check
(e.g. Apache's `StringUtils#isBlank` in commons-lang,
Spring's `StringUtils#hasText` in the Spring framework) or use a different definition of whitespace
(e.g. Google's `CharMatcher#whitespace` in Guava).
Calling `string.strip().isBlank()` is also redundant and should be simplified to `string.isBlank()`.
InefficientEmptyStringCheck (Priority: 3, Ruleset: Performance)
https://docs.pmd-code.org/snapshot/pmd_rules_java_performance.html#inefficientemptystringcheck
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L7
Avoid using hard-coded literals in conditional statements. By declaring them as static variables
or private members with descriptive names maintainability is enhanced. By default, the literals "-1" and "0" are ignored.
More exceptions can be defined with the property "ignoreMagicNumbers".
The rule doesn't consider deeper expressions by default, but this can be enabled via the property `ignoreExpressions`.
With this property set to false, if-conditions like `i == 1 + 5` are reported as well. Note that in that case,
the property ignoreMagicNumbers is not taken into account, if there are multiple literals involved in such an expression.
AvoidLiteralsInIfCondition (Priority: 3, Ruleset: Error Prone)
https://docs.pmd-code.org/snapshot/pmd_rules_java_errorprone.html#avoidliteralsinifcondition
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L7
Avoid negation within an "if" expression with an "else" clause. For example, rephrase:
`if (x != y) diff(); else same();` as: `if (x == y) same(); else diff();`.
Most "if (x != y)" cases without an "else" are often return cases, so consistent use of this
rule makes the code easier to read. Also, this resolves trivial ordering problems, such
as "does the error case go first?" or "does the common case go first?".
Since null checks are commonly considered a positive condition, they are by default ignored
by this rule. This means both `a == null` and `a != null` are allowed. If you want
to enforce either style and disallow the other, use the property `nullCheckBranch`.
ConfusingTernary (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#confusingternary
|
|
Review Code:
src/main/java/fr/insalyon/creatis/moteurlite/MoteurLite.java#L6
Reports method and constructor parameters that can be made final because they are never reassigned within the body of the method.
This rule ignores unused parameters so as not to overlap with the rule {% rule java/bestpractices/UnusedFormalParameter %}.
It will also ignore the parameters of abstract methods.
MethodArgumentCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#methodargumentcouldbefinal
|
background
wait
wait-all
cancel
parallel
Loading