sdk: report the server SDK version - #54
Conversation
AI=CLAUDE Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
a7c098e to
540545e
Compare
| /// against a real server build, so a header change that needs this bump shows up as a | ||
| /// failing job. A server release that changes no header does not, so check this value | ||
| /// when the SDK starts tracking a new release. | ||
| pub const SDK_VERSION: vef_version_t = vef_version_t { |
There was a problem hiding this comment.
Does this mean that we want to keep the versions in sync between C++ and rust SDKs? We can do that from now on.
There was a problem hiding this comment.
Yes, I think they should be in sync. Would that mean bumping C++ to 0.0.6 or changing Rust to 0.0.4?
There was a problem hiding this comment.
I believe the C++ sdk version was frozen at 0.0.4 on purpose so I don't think that one should be bumped to 0.0.6. If we make the Rust version 0.0.4 though that would break the new CI job because there's no such thing as release/0.0.4 in the server repo.
Maybe, the one version value could be split into two values? There could be a 0.0.4 version value for registration that matches the C++ SDK and it stays frozen until the C++ SDK is also bumped up so those stay synced. And then there could be a separate version value that reports 0.0.6 for the CI header check to check that headers are coming from the proper server release?
There was a problem hiding this comment.
I thought the intent was for the C++ SDK to track the server release, as we build it at the same time as the server? So it should be 0.0.6? Like here: https://github.com/villagesql/villagesql-server/releases/tag/release%2F0.0.6
3 participants
AI=CLAUDE