fix(player): guard against missing src/type in updateSourceCaches_#9202
Open
okxint wants to merge 1 commit into
Open
fix(player): guard against missing src/type in updateSourceCaches_#9202okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
When srcObj is an object without src or type properties (e.g. null or {}),
accessing srcObj.src and srcObj.type silently produced undefined values,
leading to unexpected cache state. Use optional chaining with nullish
coalescing to fall back to empty string in those cases.
Fixes videojs#9185
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
srcObjdoesn't havesrcortypekeys, both get set toundefined, which then poisons the source cache in unexpected ways. Added optional chaining + nullish coalescing fallback to empty string to match how the rest of the method handles missing values.Closes #9185