fix(packages): handle menu child mutations#1739
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (14)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
mihar-22
approved these changes
Jun 29, 2026
sampotts
force-pushed
the
fix/menu-child-mutations
branch
from
63b413d to
a722d49
Compare
sampotts
force-pushed
the
fix/menu-child-mutations
branch
from
a722d49 to
45afe5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic to handle child menu items switching between unavailable and available and correctly hiding or showing them as required.
No skin changes are included so I think we're ok to merge, @mihar-22?
Closes #1738
Note
Low Risk
Localized UI layout sync and a small HLS config-key fix with tests; no auth or data-path changes.
Overview
Open root menus now remeasure viewport size when their content changes while open—items added/removed or
data-availabilitytoggles—so--media-menu-width/--media-menu-heightstay correct when options show or hide (e.g. captions becoming available).Core adds
observeMenuViewContent, aMutationObserver(child list +data-availability, coalesced withrequestAnimationFrame). HTMLMenuElementand ReactMenuContentsubscribe while the menu is open and callsyncMenuViewRootagain (React re-renders on mutation in the custom element path).Separately,
HlsJsMediaincludes inferredcontentTypefrom the URL in the engine config key whenconfig.contentTypeis unset, so changingsrcbetween MP4 and M3U8 recreates the delegate/engine as expected.Reviewed by Cursor Bugbot for commit 45afe5a. Bugbot is set up for automated code reviews on this repo. Configure here.