fix(skin): use <media-controls-group> / <Controls.Group> components#1735
Open
sampotts wants to merge 1 commit into
Open
fix(skin): use <media-controls-group> / <Controls.Group> components#1735sampotts wants to merge 1 commit into
sampotts wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (14)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #1727 where I added
<media-controls>/<Controls.Root>, this adds usage of<media-controls-group>/<Controls.Group>components where applicable.Note
Low Risk
Markup-only refactor across preset templates with preserved class names; low chance of layout regressions unless custom CSS targeted generic divs inside controls.
Overview
Preset control bars now group related UI with
media-controls-group(HTML skins) andControls.Group(React presets) instead of bare<div>wrappers undermedia-controls/Controls.Root, continuing the controls work from #1727.The swap is applied across audio, video, and live variants (default + minimal, CSS + Tailwind). Existing layout classes (
media-button-group,media-time-controls,grow, Tailwind tokens, etc.) stay on the new elements so styling should be unchanged; only the DOM semantics change. Live layouts still use empty spacer groups where they did before (e.g.growormedia-time-controlswitharia-hidden).Reviewed by Cursor Bugbot for commit 9ade784. Bugbot is set up for automated code reviews on this repo. Configure here.