fix(skin): improvements to menu styles#1725
Merged
Merged
Conversation
❌ Deploy Preview for vjs10-site failed. Why did it fail? →
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html
Presets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react
Presets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (14)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
23a602b to
a131e9c
Compare
a131e9c to
e05f38c
Compare
Collaborator
|
haha okay you covered it here. I'll let @mihar-22 sign off |
e05f38c to
d679179
Compare
d679179 to
d5b0657
Compare
d5b0657 to
a6828ca
Compare
a6828ca to
a4dfa6f
Compare
a4dfa6f to
efcbbff
Compare
mihar-22
approved these changes
Jun 29, 2026
efcbbff to
c0dd8bd
Compare
c0dd8bd to
26bc1f4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 26bc1f4. Configure here.
26bc1f4 to
524bacb
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
max-width: nonein the calculations - this was causing issues with longer labels in the i18n work where some labels wrapped to two lines but previous logic assumed a single line (due to themax-width: none).Closes #1723
Don't merge until @mihar-22 gives the ok.
Visuals
Animations slowed to 25%.
Before
CleanShot.2026-06-23.at.10.46.49.mp4
After
CleanShot.2026-06-23.at.10.47.30.mp4
Note
Medium Risk
Touches layout measurement and positioning sync for nested settings menus across core, HTML, and React; risk is mainly visual/layout regressions rather than security, with broad but mostly CSS/preset surface area.
Overview
Menu viewport transitions now measure width and height using popover available width (
--media-popover-available-width), re-measure when that width changes during submenu navigation, and resync the active submenu when the root is still marked active. HTML and React menu content passavailableWidthintosyncMenuViewRootafter positioning (including when anchor positioning is off).Skin and preset updates align menus and popovers: settings min-width 12rem, left-aligned items, shared
menu.iconclasses, Quality icon instead of switches, quality label/tier layout tweaks, and no width/height transition on menu open/close (only while navigating). Popovers use a lighter translate + scale exit animation; default/minimal menus diverge more (padding, radius, tooltip/popover colors, anchor-based row highlight where supported). Root skins add thin scrollbars.Reviewed by Cursor Bugbot for commit 524bacb. Bugbot is set up for automated code reviews on this repo. Configure here.