feat(template): make PDP variants instant - #518
Draft
laugharn wants to merge 3 commits into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The PDP intentionally remains a blocking, coherent product route rather than exposing a generic loading shell. Once the product is loaded, however, variant interaction should not be paced by a route round trip when Shopify already provides enough encoded and sparse variant data to resolve it locally.
Verification
pnpm --dir apps/template format— passedpnpm --dir apps/template codegen— passedpnpm --dir apps/template exec next typegen— passedpnpm --dir apps/template exec tsc --noEmit— passedpnpm --dir apps/template lint— passedpnpm --dir apps/template build— passedpnpm --dir apps/template exec hydrogen gql check --fail-on-warnis currently blocked by Hydrogen/gql.tada under the workspace's TypeScript 7:TypeError: a.parseConfigFileTextToJson is not a function. The repository GraphQL codegen validated and generated the changed documents successfully.The session's tracked
apps/template/lib/shopify/transforms/image-placeholders.test.tsdoes not exist onmain; it belonged to the earlier demo branch and could not be run here.