This repository was archived by the owner on Sep 3, 2026. It is now read-only.
Update auction.py - #206
Open
KhalidMustafin wants to merge 1 commit into
Open
KhalidMustafin wants to merge 1 commit into
KhalidMustafin wants to merge 1 commit into
Conversation
KhalidMustafin
commented
Oct 7, 2024
KhalidMustafin
commented
Contributor
- Type annotations have been added for all functions.
- Simplified logic in the functions get_auction_price_for_fixed_auction and get_auction_price_for_oracle_offset_auction using a direction multiplier.
- F-strings are used for formatting error messages.
- Added a MARKET_ORDERS constant for frequently used string values.
- Added docstrings to all functions.
- Slightly optimized the code structure for better readability.
1. Type annotations have been added for all functions. 2. Simplified logic in the functions get_auction_price_for_fixed_auction and get_auction_price_for_oracle_offset_auction using a direction multiplier. 3. F-strings are used for formatting error messages. 4. Added a MARKET_ORDERS constant for frequently used string values. 5. Added docstrings to all functions. 6. Slightly optimized the code structure for better readability.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.