feat(coding-agents): carry the Codex plugin's endpoint over too - #3203
Open
nicoloboschi wants to merge 1 commit into
Open
feat(coding-agents): carry the Codex plugin's endpoint over too#3203nicoloboschi wants to merge 1 commit into
nicoloboschi wants to merge 1 commit into
Conversation
The endpoint carry-over only read ~/.hindsight/claude-code.json, so someone migrating off the Codex plugin silently landed on Cloud despite having a server configured. Codex uses the same key names in ~/.hindsight/codex.json, so one reader serves both. The agent being installed is checked first: wiring Codex must take Codex's server even when a stale claude-code.json is still present. It then falls back to any known legacy config, since one server shared by both is the common case. These two are the only superseded plugins that shipped a user config — Cursor CLI, Copilot CLI, opencode and Cline have no endpoint to carry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3193. The endpoint carry-over only read
~/.hindsight/claude-code.json, so someone migrating off the Codex plugin silently landed on Cloud despite having a server configured.Codex uses identical key names in
~/.hindsight/codex.json, so one reader serves both. The agent being installed is checked first — wiring Codex takes Codex's server even when a staleclaude-code.jsonis still lying around — then falls back to any known legacy config, since one server shared by both is the common case.Verified with both files present and conflicting URLs:
install codexpickshttp://codex-server:8888.These two are the only superseded plugins that shipped a user config; Cursor CLI, Copilot CLI, opencode and Cline have no endpoint to carry.
317 tests pass, lint clean.