Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.
This repository was archived by the owner on May 16, 2025. It is now read-only.

refactor replacing go-llsqlite/crawshaw with mattn/go-sqlite3 #482

Description

@evrins

tried replacing go-llsqlite/crawshaw with mattn/go-sqlite3
have to add compile tag nosqlite to disable go-llsqlite/crawshaw in torrent lib to make it compile or duplicate symbol erorr may occur

go-llsqlite/crawshaw in torrent is used for piece completion storage, since we have implemented , it is ok to disable it.

this change will increase binary size by 2 Mib on my mac

mattn/go-sqlite3 is database/sql compatible, we can use with pgx to reduce duplicate code

with SetMaxOpenConns(1) we can remove locked in every function call and will not trigger database is locked error

code is on branch refactor/migrate_to_mattn_go-sqlite3

@varbhat

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions