Conversation
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
…ean up comments to be around what is left of the code and nothing else Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up taking in the open source Flowstats files that we were using as a dependency and putting them in a local crate. This then has valkey-bloom depend on that local crate. Modifications that we need to do for our use-cases will then be done there.
The code taken is cleaned up for the most part with comments trimmed down to what is left. The licenses that were utilized by Flowstats are maintained and shown in the SPDX headers.