Conversation
…se branch Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
zmccoy
commented
Aug 31, 2026
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Collaborator
|
I owuld think verbatim replication is what we want as consistency is key across replica and primaries. Was there a place where you saw this wasn't the case? |
Author
|
@zackcam Nothing specific to why it wouldn't work. I think I was pattern matching off the previously done INITBYDIM and INITBYPROB which were not verbatim and followed a similar structure of not having to omit anything. For my own edification, would INITBYDIM and INITBYPROB also be able to be verbatim? For example: https://github.com/valkey-io/valkey-bloom/blob/count-min-sketch/src/cms/cms_command_handler.rs#L46-L47 ends up recreating the |
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
Signed-off-by: Zach McCoy <zmccoy@jackhenry.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked from the older branches that were in a rebase stack, this adds the merge command and testing around it for the Count Min Sketch. This is the last command we were missing.
Questions:
Notes: