Repository navigation
Valkey-bloom doesn't provide command info #71
Description
Activity
Hi, I’d like to pick up this issue and implement the SetCommandInfo support for the module API. Could you assign me? Thanks!
Hey, valkey-bloom uses the valkeymodule-rs crate and this uses the SetCommandInfo API already in the macro for command creation. Rather than implementing
SetCommandInfo, if you are interested in adding the auto complete support, you can look into this and add the KeySpec definition for the commands.Thanks :D
Reacted by Ashutosh Kumarwill work on it
Reacted by KarthikSubbaraoHi! PR #78 implements full KeySpec support for all
BF.*commands.
COMMAND INFOnow shows the correct key metadata.Argument metadata (
args:) is not included because the currentvalkeymodule-rsversion does not support it yet.A review would be appreciated!
Reacted by KarthikSubbarao@bravo1goingdark Do you intend to follow up on the PR you opened?
PR #78 is updated — per-command ACL categories restored, all 98 integration tests pass. Ready for review.
There is a module API, SetCommandInfo, which allows clients to provide argument information so that it auto-completes in some tooling like the CLI. E.X.
vs