Fix + Standardize Mouse Handling - #306
Merged
Merged
Conversation
All other input events use the property instead of using a get/set. This makes all input event structures the same.
uvcat7
self-requested a review
August 29, 2026 21:50
uvcat7
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL Mouse Fixes
Restore Right, Middle, and double click handling.
Changes caused the removal of all mouse event except single press mouse clicks, affecting text editing.
MousePress standardization
Only mouse press event used a different structure using a
unhandled()andsetHandled()function instead of use the property directly like all over input event structures.This change makes all inputs consistent.