macOS Build Support - #228
Conversation
sukibaby
changed the title
|
Looks fine so far. I would like to see some .yml files to prove the build process. Also not sure why it needs a build script; can you explain that to me? Before I merge, I'd like to get the SDL porting work done so this could be used to iterate some Mac OS builds of ArrowVortex. Hopefully that won't take too long... |
|
It doesn't need the build script, sorry for the confusion. I'll clear that out. And then hopefully I can get a yaml update here before this is merged as well :) No worries on holding off on this for now. I don't expect much to change here. |
7699d06 to
cf05fb1
Compare
4eb4350 to
ade54fd
Compare
sukibaby
changed the title
|
Re-opened and rebased following Linux support in beta. Working now on both x86_64 and arm64 macOS. Requires 
|
c6f877d to
e1d08ea
Compare
clang-tidy not available. sdl3 isn't found without the extra if apple clause.
9c84f5d to
f094f3e
Compare
|
Thanks for doing this! |
| #include <Core/Core.h> | ||
|
|
||
| #ifdef __APPLE__ | ||
| #include <OpenGL/gl.h> |
There was a problem hiding this comment.
Can you just include System/OpenGL.h instead to avoid the #ifdef spam? (and if so correct all instances of the include?)
| #pragma once | ||
|
|
||
| #ifndef APIENTRY | ||
| #define APIENTRY |
There was a problem hiding this comment.
Correct me if I'm wrong, but I thought Windows and SDL (Linux) both properly include the APIENTRY definitions. Maybe move these to the APPLE macro?
| endif() | ||
| endif() | ||
|
|
||
| if(APPLE) |
2 participants
Needed changes to allow building on macOS.
PREREQUISITES: