test : added unit tests for validate_plugins_catalog script helpers#2075
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
test : added unit tests for validate_plugins_catalog script helpers#2075tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
Owner
|
Closing as superseded by #2079, whose branch already contains this commit. Please avoid stacked duplicate PRs; keep one focused branch per reviewable change. |
utksh1
requested changes
Jul 24, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
The catalog helper coverage is a reasonable direction, but the branch fails backend-unit and has no linked assigned issue. Please add a focused issue reference, remove redundant parser-format assertions where existing CI already covers them, and fix the suite before re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2070.
Summary of What Has Been Done:
Added
testing/backend/unit/test_validate_plugins_catalog.pywith 11 unit tests covering the four helper functions inscripts/validate_plugins_catalog.py.Changes Made:
parse_plugins_md: tests for plugin entry extraction from markdown table, header row skipping, empty file handlingextract_counts_from_catalog: tests for "At a Glance" count extraction (total, safe, intrusive, exploit)extract_category_counts_from_catalog: tests for category table parsing and stopping at next section headervalidate_catalog: tests for in-sync (True, empty issues), missing from catalog, extra in catalog, count mismatch casesAll tests use
tempfile.TemporaryDirectoryfor fixture data. Tests pass withpython3 -m pytest --noconftest.Impact it Made:
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.