Skip to content

test: add unit tests for plugin_health_dashboard helpers#2031

Open
kumbharkajal wants to merge 1 commit into
utksh1:mainfrom
kumbharkajal:issue-1643-plugin-health-dashboard-tests
Open

test: add unit tests for plugin_health_dashboard helpers#2031
kumbharkajal wants to merge 1 commit into
utksh1:mainfrom
kumbharkajal:issue-1643-plugin-health-dashboard-tests

Conversation

@kumbharkajal

Copy link
Copy Markdown
Collaborator

Summary

  • Add unit tests for safe_relative_path
  • Add unit tests for discover_plugins
  • Cover empty plugin directories
  • Cover missing plugin directories
  • Cover invalid metadata.json
  • Cover plugins with and without parser.py
  • Verify plugin sorting
  • Verify metadata fallback behavior

Closes #1643

@kumbharkajal kumbharkajal self-assigned this Jul 17, 2026
@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:testing Testing work category bonus label area:ci CI, tooling, or automation work labels Jul 24, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helper coverage is reasonable, but this branch is behind main and fails backend-unit. Please rebase, fix the failing suite, and coordinate with the duplicate/stacked plugin-health test branches so this test file has one canonical PR.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helper coverage is reasonable, but this branch is behind main and fails backend-unit. Please rebase, fix the failing suite, and coordinate with the duplicate/stacked plugin-health test branches so this test file has one canonical PR.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and fix the failing backend-unit check. Keep the helper tests concise and fixture-driven; avoid duplicating the broader stacked test suite already under review in #2079.

@kumbharkajal
kumbharkajal force-pushed the issue-1643-plugin-health-dashboard-tests branch from 17419d1 to dccbfe6 Compare July 24, 2026 10:24
@kumbharkajal

Copy link
Copy Markdown
Collaborator Author

Hi @utksh1,

I've rebased my branch onto the latest main and force-pushed the updated branch.

Regarding the duplicate helper tests, my PR is focused only on the safe_relative_path and discover_plugins helper coverage for issue #1643. I'll defer to your preference on keeping a single canonical PR for this test file if you'd like these changes consolidated with #2079.

The backend-unit check is still failing, but the failures appear to be in unrelated test modules (test_saved_views.py and test_parser_sandbox_timeout_cleanup.py), which aren't touched by this PR. Please let me know if you'd like me to investigate those failures further or if they're already being handled elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci CI, tooling, or automation work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:testing Testing work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for plugin_health_dashboard helpers

2 participants